RSS Bot Posted October 3, 2022 Posted October 3, 2022 Description I notice that the first commit of armbian-next contains too many things (armbian-next: huge refactor, shellfmt, codesplit, logging/error handling). It's really hard to find out what changes we do, because we both split /lib/*.sh and change the code in one commit. It will loss the association between master and armbian-next. This PR is just split /lib/*.sh without changing any codes (except the first commit and the remove of source in /lib/main.sh). So users can find out where the codes come and then following the original commit log. If we want to merge armbian-next, this PR can make us more easily to find out the differentiation and review. If we don't merge armbian-next, this PR can let us have a more clearing structure. And it change nothing, so it still work well. IMO, we should split armbian-next into several PR. Every PR for just a feature. It will be more easy to review and we can have a clearing commit log. I can help for this. Let me known how you think about this. Note: Please just Create a merge commit instand of Squash and merge. So the commit logs can be kept. How Has This Been Tested? Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. [X] Build Checklist: [ ] My code follows the style guidelines of this project [ ] I have performed a self-review of my own code [ ] I have commented my code, particularly in hard-to-understand areas [ ] I have made corresponding changes to the documentation [ ] My changes generate no new warnings [ ] Any dependent changes have been merged and published in downstream modules View the full article
Recommended Posts