Jump to content

[Armbian build PR] - Extend BUILD_ONLY value to single value "any"


Recommended Posts

Posted

Description

This is a followup to #4455 to overcome the BUILD_ONLY empty value "dilemma" for keeping interactive dialog selection of initial BUILD_ONLY values in case nothing was set.

  • In addition to the current state we allow the value "any" for BUILD_ONLY.
  • "any" will have the same logical behavior as empty String
  • By default BUILD_ONLY will be empty String - as is currently
  • If BUILD_ONLY is empty string, we will open interactive dialog with the following pre-defined selection options (close to former KERNEL_ONLY):
    • "u-boot" - "U-Boot only build"
    • "u-boot,kernel" - "U-Boot and Kernel build only"
    • "any" - "Full SD card image build"
  • A mix of "any" with other task names in a comma separated list will be logged as error with the hint to use "any" as a single value for BUILD_ONLY only.

Reference: Followup to #4455

Testresults

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] a) KERNEL_ONLY not set, BUILD_ONLY not set: Interactive dialog for selection is shown - OK image

  • [x] b) KERNEL_ONLY=no, BUILD_ONLY not set: no dialog, BUILD_ONLY propagated to "any" - full build - OK

  • [x] c) KERNEL_ONLY=yes, BUILD_ONLY not set: no dialog, BUILD_ONLY propagated to "$(build_only_value_for_kernel_only_build)" - build of U-Boot and kernel packages - OK

  • [x] d) KERNEL_ONLY not set, BUILD_ONLY="any": no dialog, full build - OK

  • [x] e) KERNEL_ONLY not set, BUILD_ONLY="u-boot": no dialog, U-Boot build only - OK

  • [x] f) KERNEL_ONLY not set, BUILD_ONLY="any,u-boot": abort with error message "any must be single value only" - OK

  • [x] g) KERNEL_ONLY=no, BUILD_ONLY="u-boot": no dialog, warning on contradiction, BUILD_ONLY propagated to "any" - full build - OK

  • [x] h) KERNEL_ONLY=yes, BUILD_ONLY="u-boot": no dialog, warning enforcement, BUILD_ONLY propagated to "$(build_only_value_for_kernel_only_build)" - build of U-Boot and kernel packages - OK

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I will create other PR on doc repo as soon as this PR is merged
  • [x] My changes generate no new warnings
  • [n/a] Any dependent changes have been merged and published in downstream modules

View the full article

×
×
  • Create New...

Important Information

Terms of Use - Privacy Policy - Guidelines