[Armbian build PR] - rpardini's fight with space-containing PARAMs - early May/'23

[RSS Bot]

rpardini's fight with space-containing PARAMs - early May/'23

Turns out @mhoffrog was right, repeat build params need escaping. This simple rabbit goes down a hole that spans the JSON config-dump output, the pipeline JSON parsing, and the GHA matrix encoding. Phew.

• pipeline: correctly quote params passed over pure strings (eg in the GHA JSON matrixes) so values with spaces are not mangled
• bash_declare_parser: parse space-separated single-quoted array values correctly ('THIS=has space' is a single token, not two)
• aggregation: armbian_utils.parse_env_for_tokens() now actually does what it said on the box "split by whitespace, line breaks, commas, and semicolons"; add appgroups summary
• artifact-rootfs: add desktop info (environment, config_name, appgroups) to artifact_version_reason (so we can debug when I mess up later)
• configdump: alias config-dump, config-dump-json and new config-dump-no-json (bash declare format)
• produce_repeat_args_array: @mhoffrog was right, we need to quote repeat params; (here I'm being stubborn and only quoting the ones that have spaces in them)

View the full article