Jump to content

[Armbian build PR] - Update armbian-add-overlay


Recommended Posts

Posted

Description

Prior to this patch, adding a user-overlay using the script will add the filename with a space after the user-overlays=, even if there aren't any overlays present. This will result in the following: before adding: user_overlays= after adding: user_overlays= rk3588-i2c0-m1.dts

with a space. This patch will add another else branch to handle this, as well as handling any additional spaces present prior.

New script does this

before adding: user_overlays= or user_overlays= after adding: user_overlays=rk3588-i2c0-m1.dts

Adding more overlays works as intended, with a space and the name.dtbo

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] Copied conditional branch part of the code, modified changes and ran all the possible situations, worked as intended.
  • [x] Modified the script the same way on my Rock5B with Armbian Bookworm 23.5.1 install and tried adding multiple overlays, worked as intended.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
    • Not strictly required
  • [x] I have made corresponding changes to the documentation
    • Not required
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules
    • Not required

View the full article

×
×
  • Create New...

Important Information

Terms of Use - Privacy Policy - Guidelines