RSS Bot Posted December 20, 2023 Posted December 20, 2023 Description Fix compilation warnings [🐳|🔨] CC arch/arm/mach-rockchip/boot_mode.o (...) [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c: In function ‘rockchip_dnl_mode_check’: [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:174:24: warning: ‘return’ with a value, in function returning void [-Wreturn-type] [🐳|🔨] 174 | return 0; [🐳|🔨] | ^ [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:166:6: note: declared here [🐳|🔨] 166 | void rockchip_dnl_mode_check(void) [🐳|🔨] | ^~~~~~~~~~~~~~~~~~~~~~~ [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:183:24: warning: ‘return’ with a value, in function returning void [-Wreturn-type] [🐳|🔨] 183 | return 0; [🐳|🔨] | ^ [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:166:6: note: declared here [🐳|🔨] 166 | void rockchip_dnl_mode_check(void) [🐳|🔨] | ^~~~~~~~~~~~~~~~~~~~~~~ [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:196:17: warning: implicit declaration of function ‘cli_simple_run_command’ [-Wimplicit-function-declaration] [🐳|🔨] 196 | cli_simple_run_command(cmd, 0); [🐳|🔨] | ^~~~~~~~~~~~~~~~~~~~~~ [🐳|🔨] arch/arm/mach-rockchip/boot_mode.c:170:13: warning: unused variable ‘ret’ [-Wunused-variable] [🐳|🔨] 170 | int ret = 0; [🐳|🔨] | ^~~ it could be that adding the missing cli include fix functionality. So this patch might be more than cosmetic. How Has This Been Tested? Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. [ x ] compile u-boot for helios64 board (v2022.07) and boot with this u-boot. -./compile.sh uboot BOARD=helios64 BRANCH=edge RELEASE=bookworm BUILD_KSRC=no ARTIFACT_IGNORE_CACHE="yes" The CONFIG_SYS_SCSI_MAX_DEVICE definition removal from u-boot v2022.04 (as since this version this is a macro) I have only build tested with: ./compile.sh uboot BOARD=helios64 BRANCH=edge RELEASE=bookworm BUILD_KSRC=no ARTIFACT_IGNORE_CACHE="yes" BOOTBRANCH="tag:v2022.04" BOOTPATCHDIR="u-boot-rockchip64-v2022.04" Checklist: [ x ] My code follows the style guidelines of this project [ x ] I have performed a self-review of my own code [ ] I have commented my code, particularly in hard-to-understand areas [ ] I have made corresponding changes to the documentation [ x ] My changes generate no new warnings [ x ] Any dependent changes have been merged and published in downstream modules View the full article
Recommended Posts