w1_gpio module fails on ASUS Tinker Board

[Dianne S.]

Armbianmonitor:

http://ix.io/1IrG

Hi,

 

I'm running Armbian Stretch on a Tinker Board and trying to use a one-wire thermometer.  I have this in /boot/armbianEnv.txt:

 

overlays=i2c1 i2c4 spi2 spidev2 uart1 uart2 w1-gpio

However, when I boot the board, I see this in dmesg:

 

[Wed May  8 17:38:43 2019] rockchip-pinctrl pinctrl: unable to find group for node w1_pins
[Wed May  8 17:38:43 2019] w1-gpio: probe of onewire@0 failed with error -22

Kernel version is Linux tinkerboard 4.19.33-rockchip #5.77 SMP PREEMPT Wed Apr 3 17:06:29 CEST 2019 armv7l GNU/Linux

Any ideas?  I'm using the rockchip-w1-gpio.dtbo that was installed with the system.

Regards,

Dianne.

 

[TonyMac32]

Thank you for the information!  This was a carry over from Asus, I remember checking that it would load, but things may have changed in the DT.

 

+/* 1-Wire GPIO
+*  From ASUS: https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/overlays/w1-gpio-overlay.dts
+*
+*
+*/
+
+/dts-v1/;
+/plugin/;
+
+/ {
+    compatible = "rockchip,rk3288-tinker", "rockchip,rk3288";
+    fragment@0 {
+        target-path = "/";
+        __overlay__ {
+            w1: onewire@0 {
+                compatible = "w1-gpio";
+                pinctrl-names = "default";
+                pinctrl-0 = <&w1_pins>;
+                gpios = <&gpio0 17 0>;
+                status = "okay";
+            };
+        };
+    };
+
+    fragment@1 {
+        target = <&gpio0>;
+        __overlay__ {
+            w1_pins: w1_pins@0 {
+                rockchip,pins = <0 17 0 &pcfg_pull_up>;
+            };
+        };
+    };
+};

 

What your error is suggesting is that fragment 1 is failing.  I will try to take a look at this tomorrow, the u-boot debug message would be the easiest tell, it will say if something failed to apply.

[TonyMac32]

@Dianne S.

 

I was only partially right.

 

https://github.com/armbian/build/commit/5df7a1ce50529efb02c1906a71f3d89bc8546647

 

Please try the attached overlay

rockchip-w1-gpio.dtbo

[Dianne S.]

That fixed it!  Thanks so much for your quick response; that was fantastic.

 

Regards,

 

Dianne.