Jump to content

[Pull Request] - rockchip64: reworked PWM patch due to breakage in existing pwm dtbs


Recommended Posts


A recent rk356x patch changed part of pwm-rockchip.c file; in particular it adds a mandatory "active" pinctrl state, which is not expected for existing PWM users for all rockchip64 family chips (notably px30, rk3328 and rk3399) where PWM is in use and "active" pinctrl name is not provided.

In case PWM is used as modulator for some voltage regulation, may break opp and devfreq framework (in my particular case, a tv box, made cpu unable to do frequency scaling and prevented lima driver to be correctly setup).

This patch makes the "active" pinctrl state optional on v5.18 edge kernel for rockchip64.

How Has This Been Tested?

  • [x] Built kernel deb packages successfully, installed on existing rk3318 (rk3328 sibling) installation


  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

View the full article

Link to comment
Share on other sites

Armbian is a community driven open source project. Do you like to contribute your code?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...