Jump to content

[Pull Request] - rockchip64: fix pwm regulators that use pinctrl "active" configuration


Recommended Posts


After some inspections related to pwm patch recently introduced and reverted on v5.18 kernel patchset (see https://github.com/armbian/build/pull/3928), it turned out that some boards (OrangePI 4/LTS, Tinkerboard 2) use a pinctrl configuration name active which is inherited from legacy kernel. Mainline kernel does not use such pinctrl configuration name, but wants default.

This effect of this misnaming is an increased voltage supplied to "vdd_log" regulator and an increased power consumption since the configuration active is just ignored on mainline kernel.

Power consumption has been tested using a regular multimeter, on my OrangePI 4 LTS board, and with the patch applied results in a saving of ~40mA (200mW).

Jira reference number AR-1247

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] Built a Ubuntu Jammy Xfce image for OrangePI 4 LTS and tested on the board


  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

View the full article

Link to comment
Share on other sites

Donate and support the project!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...