build script improvement proposal (in case of errors)

[wildcat_paris]

Hi Igor, Hi Buddies,

 

with the new changes of *.sh files because of "2>&1" you cannot figure out the compilation errors -- or if any staling questions like

patching file tools/include/tools/be_byteshift.h
patching file tools/include/tools/le_byteshift.h
dpkg-deb: building package `linux-firmware-image-next-sunxi' in `../linux-firmware-image-next-sunxi_4.6_armhf.deb'.
gzip: ./debian/dtbtmp/usr/share/doc/linux-dtb-next-sunxi/changelog.Debian.gz already exists; do you wish to overwrite (y or n)?

so I have tried and would suggest the following changes in common.sh (or anything better for bash conditional piping)

#make $CTHREADS ARCH=arm CROSS_COMPILE="$CCACHE arm-linux-gnueabihf-" zImage modules 2>&1 | dialog --backtitle "$backtitle" --progressbox "Compiling kernel $CCACHE ..." 20 80
MKE="make $CTHREADS ARCH=arm CROSS_COMPILE=\"$CCACHE arm-linux-gnueabihf-\" zImage modules"
[[ $DEBUGKBUILD = "" ]]  && MKE="${MKE} 2>&1 | dialog --backtitle \"$backtitle\" --progressbox \"Compiling kernel $CCACHE ...\" 20 80"
eval $MKE

#make $CTHREADS ARCH=arm CROSS_COMPILE="$CCACHE arm-linux-gnueabihf-" dtbs 2>&1 | dialog --backtitle "$backtitle" --progressbox "Compiling DTB $CCACHE ..." 20 80
MKE="make $CTHREADS ARCH=arm CROSS_COMPILE=\"$CCACHE arm-linux-gnueabihf-\" dtbs"
[[ $DEBUGKBUILD = "" ]]  && MKE="${MKE} 2>&1 | dialog --backtitle \"$backtitle\" --progressbox \"Compiling DTB $CCACHE ...\" 20 80"
eval $MKE

#make -j1 $KERNEL_PACKING KDEB_PKGVERSION=$REVISION LOCALVERSION="-"$LINUXFAMILY KBUILD_DEBARCH=armhf ARCH=arm DEBFULLNAME="$MAINTAINER" \
#DEBEMAIL="$MAINTAINERMAIL" CROSS_COMPILE="$CCACHE arm-linux-gnueabihf-" 2>&1 | dialog --backtitle "$backtitle" --progressbox "Packing kernel $CCACHE ..." 20 80
MKE="\
make -j1 $KERNEL_PACKING KDEB_PKGVERSION=$REVISION LOCALVERSION=\"-\"$LINUXFAMILY KBUILD_DEBARCH=armhf ARCH=arm DEBFULLNAME=\"$MAINTAINER\" \
DEBEMAIL=\"$MAINTAINERMAIL\" CROSS_COMPILE=\"$CCACHE arm-linux-gnueabihf-\"\
"
[[ $DEBUGKBUILD = "" ]]  && MKE="${MKE} 2>&1 | dialog --backtitle \"$backtitle\" --progressbox \"Packing kernel $CCACHE ...\" 20 80"
eval $MKE

including in compile.sh

DEBUGKBUILD="yes" # if "yes" then remove dialog for debug else "" for nice dialog style

Cheers,

Mr Poor 12.34 €

[zador.blood.stained]

I had exactly this overwrite prompt when building 4.3 kernel. The reason why you can't do anything with it is not output redirection, but a dialog "window", that doesn't forward your input to the piped program.

Having option to not use dialog for all compilation commands is fine, but "DEBUGKBUILD" name can be confused with debug kernel configuration.

 

Anyway, kernel packaging should be fixed too for future builds so it requires no user interaction.

[wildcat_paris]

Hi zador.blood.stained,

I had exactly this overwrite prompt when building 4.3 kernel. The reason why you can't do anything with it is not output redirection, but a dialog "window", that doesn't forward your input to the piped program.

Having option to not use dialog for all compilation commands is fine, but "DEBUGKBUILD" name can be confused with debug kernel configuration.

 

Anyway, kernel packaging should be fixed too for future builds so it requires no user interaction.

 

YES that's why I wanted to have an option (DEBUGKBUILD or whatever keyword "Team Igor" would find nice) to be able to read compilation errors when patching or testing weird config.

 

As stated to Igor, "you cannot imagine the weird things your armbian users can do with this tool"

[zador.blood.stained]

I think I found the reason for gzip override prompt: this commit changed builddeb script https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/scripts/package/builddeb?id=8d740a37b92f3d4a0435fe263b32efc7f61c5efb

and this change conflicts with packaging-next.patch in Igor's repo, so $dtb_dir is not cleaned anymore.