• Content Count

  • Joined

  • Last visited


About chwe

  • Rank
    Embedded member

Profile Information

  • Location

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. IMO as easy as it is.. as long as we've no proper mainline drivers for the VPU stuff and 4.4 allows us to build debian/ubuntu on top of 4.4 without affecting much. we can stick to it.. I assume rockchip will rebase their BSP on something newer in the future (even their most recent SoCs are integrated into 4.4, e.g rk1808 and rk1806) and I don't think they go EOS prior to 4.4 goes EOL. Btw.. all the camera stuff also is a 4.4 only thing at the moment.. and we've a bunch of boards with doublecam ect. now.. for sure something people might get interested in once it works.. So I guess the way to go is base rockchip64 and rk3399 on the same BSP kernel (this release), base both on the same patchset (maybe this maybe next) base all on upstream u-boot (next release - rochchip64 is based on the bsp u-boot) and then we can merge it.. I guess by compile the mali stuff as modules we might get around having Utgard (rk3328) and Midgard (rk3399) in the same kernel.. and otherwise.. we may just have 2 slightly different configs whatever works here.. Or prioritize rk3399 over rk3328 in terms of mali support (we clearly see that more boards based on rk3399 are developed for those usecases - but let's call this the nuclear option.. :D)... If you feel motivated - go for it. don't let my rants about 4.4 let yourself demotivate.. :D In general I would be a fan if the buildscript allows a quick way to produce debs for custom packages. And I'll still play with 4.4 for a while anyway cause display and cameras on rk3399 are untouched till now.. and it's on my list to play with..
  2. I don't think so.. e.g. to reduce fall out we could first let both use the same kernelsoruces... then patch them until they're even and finally merge but either ditch ayufans or friendlies kernel.. one part which will mess is likely mali drivers but @JMCC knows more about that for sure.. ah and before we forget.. rk3399 boards going upstream u-boot one or the other way would also be nice..
  3. just a short one.. and I didn't read all of it.. working on: rk3399 to 5.6 (more or less done with: but testing needed especially for everything except pbp) display of pinebook pro working with mainline kernel - same PR camera working on 4.4 for pinebook - not even started yet I would love to merge rk3399 and rockchip64 bsp kernels to keep maintenance easier there - let's see if we get the mali mess sorted out there rk1808 into wip - the boards are there.. but time is missing and kernel source will be a pain maybe further cleaning of opi 4b DT
  4. didn'te expect it to work.. but well.. whatever works works..
  5. I would try "video=composite-1:d".. this goes in over u-boot variables, and they tend to mess up stuff.. cause it's then more like extraargs=video=composite-1:d whereas it should be extraargs="video=composite-1:d"..
  6. chwe

    Pinebook Pro

    likely due to some non mandatory stuff from tobias tree patched in.. usb dp altmode is currently a non issue at all for me, except it floats dmesg. tobias had a few patches for HID stuff in his tree which I didn't patch into cause I didn't expect them to be of importance.. Maybe I've a second look into that the next days.. HID leftovers I didn't patch in.. diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c index 85a054f1ce38..2aa4ed157aec 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -532,8 +532,6 @@ static const struct hid_device_id hammer_devices[] = { USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MAGNEMITE) }, { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MASTERBALL) }, - { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, - USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MOONBALL) }, { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STAFF) }, { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 9f2213426556..3a400ce603c4 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -478,7 +478,6 @@ #define USB_DEVICE_ID_GOOGLE_WHISKERS 0x5030 #define USB_DEVICE_ID_GOOGLE_MASTERBALL 0x503c #define USB_DEVICE_ID_GOOGLE_MAGNEMITE 0x503d -#define USB_DEVICE_ID_GOOGLE_MOONBALL 0x5044 #define USB_VENDOR_ID_GOTOP 0x08f2 #define USB_DEVICE_ID_SUPER_Q2 0x007f @@ -727,7 +726,6 @@ #define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085 #define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3 #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5 -#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d #define USB_VENDOR_ID_LG 0x1fd2 #define USB_DEVICE_ID_LG_MULTITOUCH 0x0064 diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index 33c102a60992..a549c42e8c90 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -458,9 +458,9 @@ static ssize_t picolcd_fb_update_rate_show(struct device *dev, if (ret >= PAGE_SIZE) break; else if (i == fb_update_rate) - ret += scnprintf(buf+ret, PAGE_SIZE-ret, "[%u] ", i); + ret += snprintf(buf+ret, PAGE_SIZE-ret, "[%u] ", i); else - ret += scnprintf(buf+ret, PAGE_SIZE-ret, "%u ", i); + ret += snprintf(buf+ret, PAGE_SIZE-ret, "%u ", i); if (ret > 0) buf[min(ret, (size_t)PAGE_SIZE)-1] = '\n'; return ret; diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 3735546bb524..0e7b2d998395 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -103,7 +103,6 @@ static const struct hid_device_id hid_quirks[] = { { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_PENSKETCH_M912), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M406XE), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2), HID_QUIRK_ALWAYS_POLL }, - { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KEYBOARD_G710_PLUS), HID_QUIRK_NOGET }, diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c index 4d25577a8573..fb827c295842 100644 --- a/drivers/hid/hid-sensor-custom.c +++ b/drivers/hid/hid-sensor-custom.c @@ -313,7 +313,7 @@ static ssize_t show_value(struct device *dev, struct device_attribute *attr, while (i < ret) { if (i + attribute->size > ret) { - len += scnprintf(&buf[len], + len += snprintf(&buf[len], PAGE_SIZE - len, "%d ", values[i]); break; @@ -336,10 +336,10 @@ static ssize_t show_value(struct device *dev, struct device_attribute *attr, ++i; break; } - len += scnprintf(&buf[len], PAGE_SIZE - len, + len += snprintf(&buf[len], PAGE_SIZE - len, "%lld ", value); } - len += scnprintf(&buf[len], PAGE_SIZE - len, "\n"); + len += snprintf(&buf[len], PAGE_SIZE - len, "\n"); return len; } else if (input) who knows..
  7. chwe


    on arm worls there's no installer for your os.. neither on fedora nor on ubuntu.. but stick to whatever fits to you bet.
  8. chwe

    Pinebook Pro

    with the newest pushed to my PR: dev images with a working display can be built, the display is currently rather dark (I guess we've to tweak the defaults from the pwm driver a bit I had it brighter in mind when using the stock OS).. The mouse is somehow bugged so an external mouse is needed and you need to build with extrawifi=no cause they didn't survive moving dev to 5.6 For those waiting for prebuilt images based on 5.6 this ain't gonna happen yet. it's simply not ready yet to deal with debug and users at the same time. And the PR involves to move pinebook to rk3399 with upstream u-boot but this goes in hand with a change in the bsp kernel (from ayufan to friendly arm) and guess what.. the display does not work there.. but mainline with 5.6-rc6 will work. The PR needs a lot of review tho.. for those wanna see a lot of errors in dmesg so to summarize: display works wifi works keyboard works desktop works touchpad doesn't everything else was not tested (ah and restart doesn't work neither atm). PR needs quite some review work and testing for other boards cause.. well we all know what happens when we switch a kernel right?
  9. chwe

    Orange pi 4 Pi 4B/ the 4b and the 4 are more or less the same except the 4b USB3 is directly wired to the SPR2801S NPU.
  10. yeah but my quick and dirty patch didn't work.. it gets applied but breaks then in packing.. do you have yours already online?
  11. btw. did you had a look at the packaging script patch? They made quite some changes in it and a quick patch reverting to the 5.3 ended in a fail.
  12. chwe

    Pinebook Pro

    well even if 5.6 fixes the display.. we've to identify what changed between 5.4 and 5.6 to backport it and get display working in 5.4. As a personal opinion current should stick to a LTS kernel for the sake of maintenance, to keep the workload lower. Fixing all the broken patches with a subversion (e.g. 5.4 to 5.5) bump soaks up a lot energy. So having at least one mainline based kernel which doesn't need that much attention would be nice to keep the stress level at an acceptable level. Additionally we've to deal with the fact that @ayufan took a step back from rockchip kernel maintenance with his fork of rockchips bsp kernel which might not be the biggest deal for rk3399 but newer SoCs (e.g. rk1808 and rk 3308) and boards based on them e.g. SoEdge from pine and RockPi S will be affected by this. In case we officially start to support those I expect quite some work on BSP kernel again.. And the pbp has a camera which nobody ever has attempted to bring up either in mainline or BSP.. It seems developers are fully confident without having a working camera no their notebooks.. On the bright side.. at least rockchip kernelwork won't get boring in the next months..
  13. chwe

    Pinebook Pro

    well our DT in is based on his DT anyway.. at least with his kernel, our special sauce config did show the display as well.. see followed by its revert. So either our special sauce in patches or our mainline kernel which is mainline for rk3399 did not work out properly.. I don't think it's the patches cause I didn't spot something obvious here. So I guess it's the kernel. and yes.. we do add the timings for the display on top of 5.4 the later as module in the PR... I pushed my 'last' changes in the PR just for the reference.. ( gave us the working display with our kernelconfig.
  14. chwe

    Pinebook Pro

    just as a side node. Tobias Schramms DT goes through peer review for mainline.
  15. chwe

    Pinebook Pro

    for the vagrant stuff.. I've no idea, never cared about it.. The board is in WIP and you need to pull from the rk3399_pinebook branch ( This branch is still some commits behind my local git and roughly 100 behind armbian master.. And it's mostly around mainline with the non working display which drives me nuts.. But maybe I take a shot with 5.5 or 5.6 were things may work.