Shoka Posted February 22, 2020 Posted February 22, 2020 This "motd" fragment has a bug/inconsistency. # any changes will be lost on board support package update THIS_SCRIPT="armbian-config" MOTD_DISABLE="" /etc/defaults/armbian-motd has : # add space-separated list of MOTD script names (without number) to exclude them from MOTD # Example: # MOTD_DISABLE="header tips updates" This works correctly for the other "motd" fragments which contain, for instance : THIS_SCRIPT="sysinfo" MOTD_DISABLE="" but fails to disable 41-armbian-config unless the MOTD_DISABLE string includes armbian-config. I've verified that nothing untoward happens if you change 41-armbian-config to THIS_SCRIPT="config" MOTD_DISABLE="" and suppression then occurs correctly with /etc/defaults/armbian-motd set to: # add space-separated list of MOTD script names (without number) to exclude them from MOTD # Example: # MOTD_DISABLE="header tips updates" MOTD_DISABLE=" header tips updates config" ONE_WIRE="" # yes = show 1-wire temperature sensor if attached On a separate, but related note, I do use the 30-armbian-sysinfo script. However my version has a minimally modified output. My modified version first. System load: 0.02 0.01 0.00 Up time: 1:18 hour Memory usage: 29 % of 238MB Zram usage: 16 % of 119Mb IP: eth0: 192.168.1.5 CPU temp: 43°C Usage of /: 5% of 29G System load: 0.02 0.01 0.00 Up time: 1:18 hour Memory usage: 29 % of 238MB Zram usage: 16 % of 119Mb IP: 192.168.1.5 CPU temp: 44°C Usage of /: 5% of 29G Note the IP information starting on a new line, and the interface information included. netadmin@probe3:~$ diff ~/motd/30-armbian-sysinfo /etc/update-motd.d/30-armbian-sysinfo 141c141 < [[ -n $tmp ]] && ips+=("$intf: $tmp") --- > #[[ -n $tmp ]] && ips+=("$intf: $tmp") 143c143 < #[[ -n $tmp ]] && ips+=("$tmp") --- > [[ -n $tmp ]] && ips+=("$tmp") 199c199 < printf "\nIP: " --- > printf "IP: " I prefer my version. I'm very much a newbie on this board, I have no idea where to post the suggestion. Cheers Harry
Igor Posted February 22, 2020 Posted February 22, 2020 3 hours ago, Shoka said: I have no idea where to post the suggestion. PR here: https://github.com/armbian/build/tree/master/packages/bsp/common/etc/update-motd.d Cheers!
Shoka Posted February 22, 2020 Author Posted February 22, 2020 Pull request generated. Will consider requesting changes to 30-armbian-sysinfo if there is consensus that that change is desirable. 1
Recommended Posts