CAN controller in BananaPi does not work in 21.05.1 image, solution available

[mue473]

Hello,

for my BananaPi I recently downloaded "Armbian_21.05.1_Bananapi_buster_current_5.10.34.img" and did not get the on-board CAN controller working with this image.

 

I found out that in sun7i-a20-bananapi.dtb (uses sun7i-a20.dtsi) the group name for the CAN pins PH20 and PH21 has changed from "can0_pins_a" to "can_ph_pins" but in the sun7i-a20-can overlay this change had not been done accordingly, and the DT merging failed.

 

So changing "sun7i-a20-can.dts" to:

/dts-v1/;
/plugin/;

/ {
	compatible = "allwinner,sun7i-a20";

	fragment@0 {
		target = <&can0>;
		__overlay__ {
			pinctrl-names = "default";
			pinctrl-0 = <&can_ph_pins>;
			status = "okay";
		};
	};
};

solved the problem.

 

Please consider this for further releases,

regards
Rainer

[TRS-80]

Hi Rainer,

 

Thanks for sharing your solution, and welcome to the forums! 

 

Do you feel up for making a PR? 

Edited June 7, 2021 by TRS-80
add link

[Werner]

Moved to proper forums.

[mue473]

vor 13 Stunden schrieb TRS-80:

Hi Rainer,

 

Thanks for sharing your solution, and welcome to the forums! 

 

Do you feel up for making a PR? 

 

Hi,

unfortunatelly I am not familiar with the procedures and tools to do this.

 

Regards,

Rainer

[TRS-80]

On 6/7/2021 at 11:31 PM, Werner said:

Moved to proper forums.

 

Shouldn't this be in bug report, so we can update the Device Tree Overlay?  Or is that maintained in Linux kernel?

[Werner]

You can see it either way: a tutorial to make CAN work or a bug report including fix.

[mue473]

In my opinion this is a bug, because using older images (I switched from Armbian Buster with kernel 4.19.62) worked without any modification of the device tree and activation of the CAN overlay normally could easily be done with armbian-config.

 

Regards,

Rainer

[Werner]

I see.

https://armbian.atlassian.net/jira/software/c/projects/AR/issues/AR-787?filter=recentlyviewed