Jump to content

Recommended Posts

Posted

Seems that USB is missing in the latest trunk pull

 

Spoiler

[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 4.13.0-sun50iw2 (root@YPC) (gcc version 7.1.1 20170707 (Linaro GCC 7.1-2017.08)) #2 SMP Mon Sep 11 23:11:59 EDT 2017
[    0.000000] Boot CPU: AArch64 Processor [410fd034]
[    0.000000] Machine model: OrangePi Zero Plus2
[    0.000000] Reserved memory: created CMA memory pool at 0x000000005c000000, size 64 MiB
[    0.000000] OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool
[    0.000000] NUMA: No NUMA configuration found
[    0.000000] NUMA: Faking a node at [mem 0x0000000000000000-0x000000005fffffff]
[    0.000000] NUMA: NODE_DATA [mem 0x5bfd5e80-0x5bfd797f]
[    0.000000] Zone ranges:
[    0.000000]   DMA      [mem 0x0000000040000000-0x000000005fffffff]
[    0.000000]   Normal   empty
[    0.000000]   Normal   empty
[    0.000000] Movable zone start for each node
[    0.000000] Early memory node ranges
[    0.000000]   node   0: [mem 0x0000000040000000-0x000000005fffffff]
[    0.000000] Initmem setup node 0 [mem 0x0000000040000000-0x000000005fffffff]
[    0.000000] On node 0 totalpages: 131072
[    0.000000]   DMA zone: 2048 pages used for memmap
[    0.000000]   DMA zone: 0 pages reserved
[    0.000000]   DMA zone: 131072 pages, LIFO batch:31
[    0.000000] psci: probing for conduit method from DT.
[    0.000000] psci: PSCIv0.2 detected in firmware.
[    0.000000] psci: Using standard PSCI v0.2 function IDs
[    0.000000] psci: Trusted OS migration not required
[    0.000000] percpu: Embedded 24 pages/cpu @ffff80001bf72000 s58520 r8192 d31592 u98304
[    0.000000] pcpu-alloc: s58520 r8192 d31592 u98304 alloc=24*4096
[    0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 
[    0.000000] Detected VIPT I-cache on CPU0
[    0.000000] CPU features: enabling workaround for ARM erratum 845719
[    0.000000] Built 1 zonelists in Node order, mobility grouping on.  Total pages: 129024
[    0.000000] Policy zone: DMA
[    0.000000] Kernel command line: root=UUID=4b616a9e-46d6-44e3-8e50-743ef47f390a rootwait rootfstype=ext4 console=tty1 console=ttyS0,115200 panic=10 consoleblank=0 loglevel=1 ubootpart=14c4796b-01 usb-storage.quirks=0x2537:0x1066:u,0x2537:0x1068:u   cgroup_enable=memory swapaccount=1
[    0.000000] log_buf_len individual max cpu contribution: 4096 bytes
[    0.000000] log_buf_len total cpu_extra contributions: 12288 bytes
[    0.000000] log_buf_len min size: 16384 bytes
[    0.000000] log_buf_len: 32768 bytes
[    0.000000] early log buf free: 13956(85%)
[    0.000000] PID hash table entries: 2048 (order: 2, 16384 bytes)
[    0.000000] Memory: 424072K/524288K available (8574K kernel code, 670K rwdata, 2264K rodata, 448K init, 320K bss, 34680K reserved, 65536K cma-reserved)
[    0.000000] Virtual kernel memory layout:
[    0.000000]     modules : 0xffff000000000000 - 0xffff000008000000   (   128 MB)
[    0.000000]     vmalloc : 0xffff000008000000 - 0xffff7dffbfff0000   (129022 GB)
[    0.000000]       .text : 0xffff000008080000 - 0xffff0000088e0000   (  8576 KB)
[    0.000000]     .rodata : 0xffff0000088e0000 - 0xffff000008b20000   (  2304 KB)
[    0.000000]       .init : 0xffff000008b20000 - 0xffff000008b90000   (   448 KB)
[    0.000000]       .data : 0xffff000008b90000 - 0xffff000008c37808   (   671 KB)
[    0.000000]        .bss : 0xffff000008c37808 - 0xffff000008c87bd8   (   321 KB)
[    0.000000]     fixed   : 0xffff7dfffe7fd000 - 0xffff7dfffec00000   (  4108 KB)
[    0.000000]     PCI I/O : 0xffff7dfffee00000 - 0xffff7dffffe00000   (    16 MB)
B maximum)
[    0.000000]               0xffff7e0000000000 - 0xffff7e0000800000   (     8 MB actual)
[    0.000000]     memory  : 0xffff800000000000 - 0xffff800020000000   (   512 MB)
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
[    0.000000] Hierarchical RCU implementation.
[    0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0
[    0.000000] GIC: Using split EOI/Deactivate mode
[    0.000000] arch_timer: cp15 timer(s) running at 24.00MHz (phys).
[    0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x588fe9dc0, max_idle_ns: 440795202592 ns
[    0.000005] sched_clock: 56 bits at 24MHz, resolution 41ns, wraps every 4398046511097ns
[    0.000131] Console: colour dummy device 80x25
[    0.000144] console [tty1] enabled
[    0.000197] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=96000)
[    0.000206] pid_max: default: 32768 minimum: 301
[    0.000289] Security Framework initialized
[    0.000297] AppArmor: AppArmor disabled by boot time parameter
[    0.000664] Dentry cache hash table entries: 65536 (order: 7, 524288 bytes)
[    0.000848] Inode-cache hash table entries: 32768 (order: 6, 262144 bytes)
[    0.000872] Mount-cache hash table entries: 1024 (order: 1, 8192 bytes)
[    0.000888] Mountpoint-cache hash table entries: 1024 (order: 1, 8192 bytes)
[    0.002001] ASID allocator initialised with 65536 entries
[    0.002063] Hierarchical SRCU implementation.
[    0.002425] smp: Bringing up secondary CPUs ...
[    0.003509] Detected VIPT I-cache on CPU1
[    0.003563] CPU1: Booted secondary processor [410fd034]
[    0.004277] Detected VIPT I-cache on CPU2
[    0.004303] CPU2: Booted secondary processor [410fd034]
[    0.004963] Detected VIPT I-cache on CPU3
[    0.004988] CPU3: Booted secondary processor [410fd034]
[    0.005043] smp: Brought up 1 node, 4 CPUs
[    0.005047] SMP: Total of 4 processors activated.
[    0.005053] CPU features: detected feature: 32-bit EL0 Support
[    0.005161] CPU: All CPU(s) started at EL2
[    0.005180] alternatives: patching kernel code
[    0.005982] devtmpfs: initialized
[    0.010156] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
[    0.010205] futex hash table entries: 1024 (order: 5, 131072 bytes)
[    0.012549] xor: measuring software checksum speed
[    0.052177]    8regs     :  1566.000 MB/sec
[    0.092217]    8regs_prefetch:  1396.000 MB/sec
[    0.132270]    32regs    :  1925.000 MB/sec
[    0.172310]    32regs_prefetch:  1618.000 MB/sec
[    0.172314] xor: using function: 32regs (1925.000 MB/sec)
[    0.172325] pinctrl core: initialized pinctrl subsystem
[    0.173027] random: get_random_u32 called from bucket_table_alloc+0x10c/0x260 with crng_init=0
[    0.173111] NET: Registered protocol family 16
[    0.174054] cpuidle: using governor menu
[    0.174649] vdso: 2 pages (1 code @ ffff0000088e6000, 1 data @ ffff000008b94000)
[    0.174663] hw-breakpoint: found 6 breakpoint and 4 watchpoint registers.
[    0.176687] DMA: preallocated 2048 KiB pool for atomic allocations
[    0.176740] Serial: AMBA PL011 UART driver
[    0.185280] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages
[    0.252457] raid6: int64x1  gen()   281 MB/s
[    0.320496] raid6: int64x1  xor()   310 MB/s
[    0.388691] raid6: int64x2  gen()   443 MB/s
[    0.456683] raid6: int64x2  xor()   403 MB/s
[    0.524742] raid6: int64x4  gen()   703 MB/s
[    0.592821] raid6: int64x4  xor()   498 MB/s
[    0.660877] raid6: int64x8  gen()   666 MB/s
[    0.728902] raid6: int64x8  xor()   507 MB/s
[    0.797068] raid6: neonx1   gen()   490 MB/s
[    0.865089] raid6: neonx1   xor()   494 MB/s
[    0.933163] raid6: neonx2   gen()   784 MB/s
[    1.001209] raid6: neonx2   xor()   696 MB/s
[    1.069279] raid6: neonx4   gen()  1022 MB/s
[    1.137335] raid6: neonx4   xor()   799 MB/s
[    1.205411] raid6: neonx8   gen()  1072 MB/s
[    1.273462] raid6: neonx8   xor()   814 MB/s
[    1.273465] raid6: using algorithm neonx8 gen() 1072 MB/s
[    1.273467] raid6: .... xor() 814 MB/s, rmw enabled
[    1.273470] raid6: using intx1 recovery algorithm
[    1.274100] SCSI subsystem initialized
[    1.274267] usbcore: registered new interface driver usbfs
[    1.274301] usbcore: registered new interface driver hub
[    1.274348] usbcore: registered new device driver usb
[    1.274504] pps_core: LinuxPPS API ver. 1 registered
[    1.274507] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti <giometti@linux.it>
[    1.274524] PTP clock support registered
[    1.274772] Advanced Linux Sound Architecture Driver Initialized.
[    1.275485] clocksource: Switched to clocksource arch_sys_counter
[    1.275666] VFS: Disk quotas dquot_6.6.0
[    1.275720] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
[    1.281691] NET: Registered protocol family 2
[    1.282214] TCP established hash table entries: 4096 (order: 3, 32768 bytes)
[    1.282277] TCP bind hash table entries: 4096 (order: 4, 65536 bytes)
[    1.282365] TCP: Hash tables configured (established 4096 bind 4096)
[    1.282461] UDP hash table entries: 256 (order: 1, 8192 bytes)
[    1.282482] UDP-Lite hash table entries: 256 (order: 1, 8192 bytes)
[    1.282640] NET: Registered protocol family 1
[    1.282951] RPC: Registered named UNIX socket transport module.
[    1.282954] RPC: Registered udp transport module.
[    1.282956] RPC: Registered tcp transport module.
[    1.282959] RPC: Registered tcp NFSv4.1 backchannel transport module.
[    1.283136] Unpacking initramfs...
[    1.571261] Freeing initrd memory: 4880K
[    1.572400] random: fast init done
[    1.575237] audit: initializing netlink subsys (disabled)
[    1.575348] audit: type=2000 audit(1.571:1): state=initialized audit_enabled=0 res=1
[    1.575675] workingset: timestamp_bits=44 max_order=17 bucket_order=0
[    1.580666] zbud: loaded
[    1.582202] squashfs: version 4.0 (2009/01/31) Phillip Lougher
[    1.582805] NFS: Registering the id_resolver key type
[    1.582833] Key type id_resolver registered
[    1.582836] Key type id_legacy registered
[    1.582846] nfs4filelayout_init: NFSv4 File Layout Driver Registering...
[    1.582850] Installing knfsd (copyright (C) 1996 okir@monad.swb.de).
[    1.583650] 9p: Installing v9fs 9p2000 file system support
[    1.588311] NET: Registered protocol family 38
[    1.588570] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 249)
[    1.588663] io scheduler noop registered
[    1.588667] io scheduler deadline registered
[    1.588787] io scheduler cfq registered (default)
[    1.588790] io scheduler mq-deadline registered
[    1.588794] io scheduler kyber registered
[    1.588827] io scheduler bfq registered
[    1.590750] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver
[    1.593142] sun50i-h5-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver
[    1.664532] ------------[ cut here ]------------
[    1.664554] WARNING: CPU: 0 PID: 1 at drivers/clk/sunxi-ng/ccu_common.c:41 ccu_helper_wait_for_lock.part.0+0x88/0xa0
[    1.664557] Modules linked in:
[    1.664568] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-sun50iw2 #2
[    1.664571] Hardware name: OrangePi Zero Plus2 (DT)
[    1.664575] task: ffff80001a910000 task.stack: ffff80001a918000
[    1.664580] PC is at ccu_helper_wait_for_lock.part.0+0x88/0xa0
[    1.664586] LR is at ccu_helper_wait_for_lock.part.0+0x40/0xa0
045
[    1.664592] sp : ffff80001a91ba70
[    1.664594] x29: ffff80001a91ba70 x28: ffff800019709d80 
[    1.664601] x27: ffff000008a76000 x26: ffff000008a79ed8 
[    1.664608] x25: ffff000008a79e30 x24: 00000000016e3600 
[    1.664614] x23: ffff000008bf0318 x22: 0000000000000001 
[    1.664621] x21: 0000000010000000 x20: 0000000062ff8b1a 
[    1.664627] x19: 0000000003001100 x18: 0000000000000001 
[    1.664633] x17: 0000000000000001 x16: 0000000000000071 
[    1.664639] x15: ffffffffffffffff x14: 000000006335aa61 
[    1.664646] x13: 0000000000000000 x12: ffff80001a910100 
[    1.664652] x11: 0000000000000000 x10: 0000000000000980 
[    1.664658] x9 : ffff80001a91b910 x8 : ffff80001a9109e0 
[    1.664665] x7 : ffffffffffd227d5 x6 : 000000000f6f2a07 
[    1.664671] x5 : 00ffffffffffffff x4 : 002756cd002f5d00 
[    1.664677] x3 : 0000000000000018 x2 : 0000000000000342 
[    1.664683] x1 : 0000000029aaaaab x0 : 000000006300d293 
[    1.664691] Call trace:
[    1.664696] Exception stack(0xffff80001a91b8a0 to 0xffff80001a91b9d0)
[    1.664702] b8a0: 0000000003001100 0001000000000000 ffff80001a91ba70 ffff000008562d10
[    1.664708] b8c0: ffff80001a91b8d0 ffff0000080d6fd4 ffff80001a91b8f0 ffff0000080d729c
[    1.664714] b8e0: ffff80001a910100 ffff80001a910000 ffff80001a91b930 ffff0000088d49c0
[    1.664720] b900: ffff80001bf7f280 ffff80001a910000 ffff000008ba0f80 ffff000008bb9ad0
[    1.664725] b920: ffff000008b7f000 ffff0000088d4ddc ffff80001a91b990 ffff0000088d4ddc
[    1.664731] b940: 000000006300d293 0000000029aaaaab 0000000000000342 0000000000000018
[    1.664736] b960: 002756cd002f5d00 00ffffffffffffff 000000000f6f2a07 ffffffffffd227d5
[    1.664742] b980: ffff80001a9109e0 ffff80001a91b910 0000000000000980 0000000000000000
[    1.664748] b9a0: ffff80001a910100 0000000000000000 000000006335aa61 ffffffffffffffff
[    1.664752] b9c0: 0000000000000071 0000000000000001
[    1.664757] [<ffff000008562d10>] ccu_helper_wait_for_lock.part.0+0x88/0xa0
[    1.664763] [<ffff000008562db8>] ccu_helper_wait_for_lock+0x10/0x20
[    1.664771] [<ffff0000085655ec>] ccu_nm_set_rate+0x194/0x200
[    1.664780] [<ffff00000855b818>] clk_change_rate+0x1b0/0x270
[    1.664786] [<ffff00000855b93c>] clk_core_set_rate_nolock+0x64/0xd0
[    1.664792] [<ffff00000855b9d8>] clk_set_rate+0x30/0x50
[    1.664797] [<ffff0000085601d4>] of_clk_set_defaults+0x1e4/0x378
[    1.664807] [<ffff0000085f95d4>] platform_drv_probe+0x24/0xb8
[    1.664813] [<ffff0000085f7a48>] driver_probe_device+0x228/0x2d0
[    1.664819] [<ffff0000085f7ba8>] __driver_attach+0xb8/0xc0
[    1.664825] [<ffff0000085f5c9c>] bus_for_each_dev+0x4c/0x98
[    1.664831] [<ffff0000085f7370>] driver_attach+0x20/0x28
[    1.664836] [<ffff0000085f6f6c>] bus_add_driver+0x1b4/0x220
[    1.664842] [<ffff0000085f8538>] driver_register+0x60/0xf8
[    1.664848] [<ffff0000085f9558>] __platform_driver_register+0x40/0x48
[    1.664856] [<ffff000008b3f3c8>] sunxi_de2_clk_driver_init+0x18/0x20
[    1.664864] [<ffff000008082900>] do_one_initcall+0x38/0x120
[    1.664874] [<ffff000008b20cb8>] kernel_init_freeable+0x18c/0x230
[    1.664880] [<ffff0000088d3b08>] kernel_init+0x10/0x100
[    1.664885] [<ffff0000080826c0>] ret_from_fork+0x10/0x50
[    1.664895] ---[ end trace 0dfcc846c0a987f5 ]---
[    1.669769] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
[    1.670823] console [ttyS0] disabled
[    1.690956] 1c28000.serial: ttyS0 at MMIO 0x1c28000 (irq = 16, base_baud = 1500000) is a U6_16550A
[    1.691006] console [ttyS0] enabled
[    1.691662] cacheinfo: Unable to detect cache hierarchy for CPU 0
[    1.695827] loop: module loaded
[    1.696408] libphy: Fixed MDIO Bus: probed
[    1.696869] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
[    1.696873] ehci-platform: EHCI generic platform driver
[    1.696933] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
[    1.696943] ohci-platform: OHCI generic platform driver
[    1.697055] usbcore: registered new interface driver usb-storage
[    1.697274] mousedev: PS/2 mouse device common for all mice
[    1.697690] sun6i-rtc 1f00000.rtc: rtc core: registered rtc-sun6i as rtc0
[    1.697695] sun6i-rtc 1f00000.rtc: RTC enabled
[    1.697725] i2c /dev entries driver
[    1.698282] thermal thermal_zone0: failed to read out thermal zone (-16)
[    1.698558] sdhci: Secure Digital Host Controller Interface driver
[    1.698561] sdhci: Copyright(c) Pierre Ossman
[    1.698580] Synopsys Designware Multimedia Card Interface Driver
[    1.699944] sunxi-mmc 1c0f000.mmc: Got CD GPIO
[    1.739625] sunxi-mmc 1c0f000.mmc: base:0xffff000009038000 irq:7
[    1.779503] sunxi-mmc 1c11000.mmc: base:0xffff00000903c000 irq:8
[    1.779590] sdhci-pltfm: SDHCI platform and OF driver helper
[    1.780116] ledtrig-cpu: registered to indicate activity on CPUs
[    1.780282] hidraw: raw HID events driver (C) Jiri Kosina
[    1.780470] usbcore: registered new interface driver usbhid
[    1.780473] usbhid: USB HID core driver
[    1.780845] ip_tables: (C) 2000-2006 Netfilter Core Team
[    1.781265] NET: Registered protocol family 10
[    1.794284] mmc0: host does not support reading read-only switch, assuming write-enable
[    1.797130] Segment Routing with IPv6
[    1.797212] NET: Registered protocol family 17
[    1.797287] 8021q: 802.1Q VLAN Support v1.8
[    1.797335] 9pnet: Installing 9P2000 support
[    1.797418] Key type dns_resolver registered
[    1.797925] mmc0: new high speed SDHC card at address 0007
[    1.798133] registered taskstats version 1
[    1.798235] zswap: loaded using pool lzo/zbud
[    1.798371] mmcblk0: mmc0:0007 SD32G 29.0 GiB 
[    1.799289] Btrfs loaded, crc32c=crc32c-arm64-ce
[    1.799581]  mmcblk0: p1
[    1.806280] Key type encrypted registered
[    1.811112] of_cfs_init
[    1.811198] of_cfs_init: OK
[    1.811353] ALSA device list:
[    1.811356]   No soundcards found.
[    1.811929] Freeing unused kernel memory: 448K
[    1.852837] mmc1: new high speed MMC card at address 0001
[    1.853470] mmcblk1: mmc1:0001 8WPD3R 7.28 GiB 
[    1.853693] mmcblk1boot0: mmc1:0001 8WPD3R partition 1 4.00 MiB
[    1.853900] mmcblk1boot1: mmc1:0001 8WPD3R partition 2 4.00 MiB
[    1.855315]  mmcblk1: p1 p2 p3 < p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 p16 p17 >
[    1.855344] mmcblk1: p1 size 6873088 extends beyond EOD, truncated
[    3.051311] EXT4-fs (mmcblk0p1): mounted filesystem with writeback data mode. Opts: (null)
[    3.474961] systemd[1]: System time before build time, advancing clock.
[    3.506106] systemd[1]: systemd 229 running in system mode. (+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD -IDN)
[    3.506480] systemd[1]: Detected architecture arm64.
[    3.520494] systemd[1]: Set hostname to <orangepizeroplus2>.
[    3.867605] systemd[1]: Listening on fsck to fsckd communication Socket.
[    3.879808] systemd[1]: Listening on Journal Socket.
[    3.891754] systemd[1]: Started Forward Password Requests to Wall Directory Watch.
[    3.903980] systemd[1]: Created slice System Slice.
[    3.917789] systemd[1]: Starting Create list of required static device nodes for the current kernel...
[    3.935858] systemd[1]: Listening on udev Kernel Socket.
[    3.949531] systemd[1]: Starting Nameserver information manager...
[    4.191769] EXT4-fs (mmcblk0p1): re-mounted. Opts: commit=600,errors=remount-ro
[    4.613426] Adding 131068k swap on /var/swap.  Priority:-1 extents:1 across:131068k SSFS
from PID 1
[    6.280149] random: crng init done
[    6.568597] Bluetooth: Core ver 2.22
[    6.568700] NET: Registered protocol family 31
[    6.568704] Bluetooth: HCI device and connection manager initialized
[    6.568726] Bluetooth: HCI socket layer initialized
[    6.568740] Bluetooth: L2CAP socket layer initialized
[    6.568774] Bluetooth: SCO socket layer initialized
root@orangepizeroplus2:~# 

 

 

lsusb -v shows nothing

 

 

Posted

 

Reinstalled using all the nightlies, all of the have missing USB Drivers

 

Armbian_5.34.171026_Orangepizeroplus2-h5_Ubuntu_xenial_next_4.13.9.7z 2017-10-25 03:56 228.0 MB
ar-ubuntu-server Armbian_5.34.171027_Orangepizeroplus2-h5_Ubuntu_xenial_next_4.13.9.7z 2017-10-26 03:57 233.7 MB
ar-ubuntu-server Armbian_5.34.171028_Orangepizeroplus2-h5_Ubuntu_xenial_next_4.13.9.7z 2017-10-27 04:41 235.9 MB
ar-ubuntu-server Armbian_5.34.171029_Orangepizeroplus2-h5_Ubuntu_xenial_next_4.13.10.7z

 

Posted (edited)

USB is disable in Driver Tree files.

 

You can convert DTB to DTS and modify this. 

I don´t know  why. 

 

 

I have edited the file and I have modified the disable references for okay of the USB and they have worked for me

Edited by Paco
Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

Terms of Use - Privacy Policy - Guidelines