Jump to content

Recommended Posts

Posted (edited)

How did you determine which configs to edit?

Can I simply send a PR without testing? I guess there is a CI behind which takes care of testing?

Edited by Scritch
Posted

I'd check all "edge" configs for the presence of usbip. at one of those at least a build test should occur

Posted (edited)

I see. I will check.

 

Furthermore: The usbip config was present but got lost between Armbian 26.2 and 26.5.

 

I see frequent PRs which do "Automatic: kernel config rewrite". How can we make sure these changes get persisted and not lost again? However the automated kernel config rewrite works, also needs to consider usbip.

 

Edit: In concrete, it got removed with PR 9381: https://github.com/armbian/build/pull/9381/changes?mode=single#diff-9a3979f7f80525cd7ddd10a00d15aa3e4156c49357184ef9405432599e85a588

 

The PR talks about "groundhog day". I guess there is a process behind to "generate" a more than 100k lines PR?

Edited by Scritch
Posted
2 hours ago, Scritch said:

"groundhog day".

hehe, yes. because on every new major kernel version the same stuff occurs: rollover and adjust the (huge) patchset to the new version. Because patches were copied, this resulted in these large line numbers.

 

in any case, kernel rewrite addresses things like unmet dependencies, hence throwing stuff out which would not work this way anyway. to make sure it is persistent, use kernel-config to spawn a menu config and enable the necessary options. The resulting kernel config should persist.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
×
×
  • Create New...

Important Information

Terms of Use - Privacy Policy - Guidelines