Immament major changes in rk3588s-orangepi-5* DTS files.

[Rocksheep]

Hi.
According to this patch Orange pi 5 Pro DTS (which BTW i use for my successful Orange Pi 5 Pro edge build) there will be a split of DTSI files. Most of the code in rk3588s-orangepi-5.dtsi will be transferred to new rk3588s-orangepi-5-5b.dtsi. In my current build for Orange Pi 5 and 5 Pro I have: rk3588s-orangepi-5-5b.dtsi  rk3588s-orangepi-5b.dts  rk3588s-orangepi-5.dts  rk3588s-orangepi-5.dtsi  rk3588s-orangepi-5-pro.dts. Please note I have Orange Pi 5 Pro with SPI chip soldered on so for Orange Pi 5 Pro build with EMMC (99.99% of cases) in rk3588s-orangepi-5-pro.dts set:
 

/* SFC */
&sfc {
        status = "disabled";
};

and
 

&sdhci {
        status = "okay";
};

 

rk3588s-orangepi-5-pro.dts rk3588s-orangepi-5b.dts rk3588s-orangepi-5-5b.dtsi rk3588s-orangepi-5.dtsi rk3588s-orangepi-5.dts

Edited yesterday at 12:04 PM by Rocksheep

[Werner]

If you want to do the work you can open a pr including these changes into Armbian. However I believe all opi5* boards are in decent state I'd simply wait for upstream .

the patchew link is dead btw.

[Rocksheep]

I was just giving heads up. Basically patch is ready with only few "naming disagreements" and  reviewers wants to push it upstream soon probably still within 7.1 release candidate. Once it will happen all the builds for orange pi 5/5b/pro and so on will fail so its worth to be prepared.

[Werner]

6 minutes ago, Rocksheep said:

Once it will happen all the builds for orange pi 5/5b/pro and so on will fail so its worth to be prepared.

Why should they?

[Rocksheep]

If i recall correctly this patch is causing problems:
patch/kernel/archive/rockchip64-7.0/rk3588-1221-arm64-fix-typec-for-orangepi-5-5b.patch
After split the code it wants to patch has will be moved from
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi
to
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi
Anyway I'm not sure what this patch meant to fix. Can't find much info on it but it looks like the altmodes block is advertising DP mode over USB-C so enables port to transmit direct video and audio signals. Please someone correct me on this one if I'm wrong. If so it adds future to the system rather then fixing it. I think its better to leave it at default source - host mode.

[Werner]

perhaps the patch is no longer necessary once this lands upstream. We will see once we get there

[Rocksheep]

I just checked and Orange Pi 5 is capable of DP mode over usb-c. I assume that patch has been tested and if it works (I might test it myself some time in near future) it is worth to keep.