Odroid M1S Image Planned ?

[Werner]

Did you check already merged PRs which were adding new boards? Like https://github.com/armbian/build/pull/8754/files

Should give some clues.

[Jojo]

6 hours ago, Werner said:

Did you check already merged PRs which were adding new boards? Like https://github.com/armbian/build/pull/8754/files

Should give some clues.

Thank you for your reply!

No, I did not check THIS SPECIFIC PR. But of course the other ones, for example those @Igor already pointed to.

And because of the fact, that I already checked several PR and still being not sure how to do it correctly, I hoped for a more general explanation than just another link to another PR...

 

I wished for some explanations about good practice and how/why things are done the way they are done.

"Path xyz is the place for your .csc files. Path abc for your .dts files because of blablabla..." That would just have been nice to get a better overview.

Beside all the respect and appreciation that I have for you and your colleagues at Armbian, please understand that it is sometimes somewhat exhausting when guys like me try their very best to contribute and then often get calmed by link-drops...

 

Anyway, I'll check out your referred PR and see if that helps.

 

Edited 4 hours ago by Jojo

[Werner]

We're aware that our documentation isn't great (also about adding new hw: https://docs.armbian.com/Process_Contribute/#adding-a-new-board) but it is hard to find time for such tasks when we're crowded with other stuff already.

 

Quote

To me it seems that this requires not "normal" .config files, but ".csc" files.

The file extension defines a boards support status. https://docs.armbian.com/User-Guide_Board-Support-Rules/

Anyone can add .csc boards.

 

For dts files we have dedicated folders to avoid having a patch necessary for them:

https://github.com/armbian/build/tree/main/patch/kernel/archive/rockchip64-6.12/dt

https://github.com/armbian/build/tree/main/patch/kernel/archive/rockchip64-6.18/dt

 

[Jojo]

2 hours ago, Werner said:

We're aware that our documentation isn't great (also about adding new hw: https://docs.armbian.com/Process_Contribute/#adding-a-new-board) but it is hard to find time for such tasks when we're crowded with other stuff already.

Understood, all good.

 

2 hours ago, Werner said:

For dts files we have dedicated folders to avoid having a patch necessary for them:

https://github.com/armbian/build/tree/main/patch/kernel/archive/rockchip64-6.12/dt

https://github.com/armbian/build/tree/main/patch/kernel/archive/rockchip64-6.18/dt

That is a good example for something that is not that clear.

I tried to find a ready-to-use dts file for the M1S in the mainline repo, but it is not one single dts file, but a composition of several files where one file refers to the next one and so on (here). I was confused and so I asked ChatGPT how to merge the mainline dts into Armbian. This was how my patches were created.

After compilation there was indeed one single all-in-one dts file for my board but not before...

EDIT: I just tried another build with just taking the top-level dts file from the mainline repo and placing it in the location you mentioned. Worked like a charm, despite my confusion... 😅

 

From my point of view it seemed better to have the patches in place to be sure to always pull the most recent DT from the mainline kernel (that of course would require a defined place to put those patches).

But what you say sounds as if it would be preferable to have dts files instead of patches. Is that correct and why?

Edited 1 hour ago by Jojo