martinayotte Posted April 5, 2019 Author Posted April 5, 2019 On 4/5/2019 at 5:41 PM, dreddit said: The legacy fix involves the PH07 but find no reference on the board unless it refers to a gpio pin? Expand Yes, but this PH7 is the SPDIF-OUT for Audio, which is not even connect on OPi3. I doubt this fix has anything to do with reboot issue, especially that this FEX attached this PH7 to "recovery" button ...
martinayotte Posted April 5, 2019 Author Posted April 5, 2019 On 4/5/2019 at 5:41 PM, dreddit said: The legacy fix involves the PH07 but find no reference on the board unless it refers to a gpio pin? Expand Yes, but this PH7 is the SPDIF-OUT for Audio, which is not even connect on OPi3. I doubt this fix has anything to do with reboot issue, especially that this FEX attached this PH7 to "recovery" button ...
martinayotte Posted April 5, 2019 Author Posted April 5, 2019 On 4/5/2019 at 5:41 PM, dreddit said: The legacy fix involves the PH07 but find no reference on the board unless it refers to a gpio pin? Expand Yes, but this PH7 is the SPDIF-OUT for Audio, which is not even connect on neither OPi3, OPiOnePlus or OPiLite2. I doubt this fix has anything to do with reboot issue, especially that this FEX attached this PH7 to "recovery" button ...
frozeus Posted April 7, 2019 Posted April 7, 2019 SPIDF-OUT is PL9. I think the legacy version doesn't use the watchdog or not the same to reboot the board. EDIT: I think it uses the ARISC co-processor does someone with the h64 can test if the WDOG works ? /* This should reset the system after 0.5s */ # devmem $((0x030090a0 + 0x0014)) 0x00000001 # devmem $((0x030090a0 + 0x0018)) 0x00000000 # devmem $((0x030090a0 + 0x0018)) 32 0x1 /* This should reset the system after 1s (as recommended in the User Manual) */ # devmem $((0x030090a0 + 0x0014)) 0x00000001 # devmem $((0x030090a0 + 0x0018)) 0x00000000 # devmem $((0x030090a0 + 0x0018)) 32 $((0x1 << 4)) # devmem $((0x030090a0 + 0x0018)) 0x00000010 # devmem $((0x030090a0 + 0x0018)) 32 $((0x1 << 4 | 0x1))
frozeus Posted April 7, 2019 Posted April 7, 2019 Changing to the R_WDOG instead of WDOG in ATF fix the issue. 0001-HACK-plat-allwinner-common-Use-R_WDOG.patchFetching info...
martinayotte Posted April 7, 2019 Author Posted April 7, 2019 On 4/7/2019 at 3:40 PM, froezus said: SPIDF-OUT is PL9. Expand You are better looking at the schematic of any H6 (OPi3, OPiOnePlus, OPILite2) before arguing, PL9 is S-IR-RX, PH7 is really SPDIF-OUT ...
martinayotte Posted April 7, 2019 Author Posted April 7, 2019 On 4/7/2019 at 8:36 PM, froezus said: Changing to the R_WDOG instead of WDOG in ATF fix the issue. Expand Where did you find this patch ? We are not seeing it on linux-sunxi ML ... Did you tried out ?
frozeus Posted April 7, 2019 Posted April 7, 2019 On 4/7/2019 at 9:18 PM, martinayotte said: You are better looking at the schematic of any H6 (OPi3, OPiOnePlus, OPILite2) before arguing, PL9 is S-IR-RX, PH7 is really SPDIF-OUT ... Expand Oups indeed, My brain switch between IR and SPDIF. The patch is from me and yes I tested it. Still not posted it because it's more a hack.
martinayotte Posted April 7, 2019 Author Posted April 7, 2019 On 4/7/2019 at 9:29 PM, froezus said: The patch is from me and yes I tested it. Still not posted it because it's more a hack. Expand Oh ! So, @froezus is in fact Clément Péron ? Alors, bienvenue sur Armbian ... Je preśume que tu es basé en France, selon l'heure de ta patch ? Moi, je suis au Québec ... Je vais donc essayer celle-ci sous peu ! Salutation !
frozeus Posted April 7, 2019 Posted April 7, 2019 On 4/7/2019 at 9:36 PM, martinayotte said: Oh ! So, @froezus is in fact Clément Péron ? Alors, bienvenue sur Armbian ... Je preśume que tu es basé en France, selon l'heure de ta patch ? Moi, je suis au Québec ... Je vais donc essayer celle-ci sous peu ! Salutation ! Expand Oui, salutation à toi aussi !
martinayotte Posted April 8, 2019 Author Posted April 8, 2019 On 4/7/2019 at 9:29 PM, froezus said: The patch is from me and yes I tested it. Still not posted it because it's more a hack. Expand Did you got chance to figure out if the changes breaks or works for H3/H5/A64 ? If not, we will need to build different BL31 for H6 differently from H3/H5/A64, since I'm not fluent with ATF, I'm not even sure that Armbian scripts distinguish between those ATF flavors accordingly ... Did you exchange discussions with @megi and @Icenowy and any other about the issue ? Maybe the Official ML will still be a good place ... Thanks for your work, since we struggling about the issue since at least 3 months ...
megi Posted April 8, 2019 Posted April 8, 2019 @froezus Nice! Thank you. I've changed your patch, so that it uses R_WDOG only on H6. https://megous.com/dl/tmp/0001-Fix-reset-issue-on-H6-by-using-R_WDOG.patch It's still a hack, but at least it doesn't touch other SoCs. U-boot will also need patching, because it doesn't use ATF for reset. I tested it on Opi3, and it works. :)) 1
frozeus Posted April 8, 2019 Posted April 8, 2019 Before trying any patch it would better to first understand, how it works on PineH64.
ilchenko Evgeny Posted April 8, 2019 Posted April 8, 2019 On 4/8/2019 at 8:38 AM, froezus said: Before trying any patch it would better to first understand, how it works on PineH64. Expand please tell us how to install this patch
frozeus Posted April 8, 2019 Posted April 8, 2019 You just need to put it in build/patch/atf/atf-sunxi64/
martinayotte Posted April 8, 2019 Author Posted April 8, 2019 On 4/8/2019 at 1:52 AM, megi said: U-boot will also need patching, because it doesn't use ATF for reset. Expand What would be this second patch for the U-Boot "reset" ? EDIT : for the "reboot" patch, I'm confirming : it works ! Thanks a lot to both @froezus and @megi !!! EDIT2 : tested on all my H6, OPiOne+/OPiLite2/OPi3 ... And patch committed in Armbian ! 4
frozeus Posted April 8, 2019 Posted April 8, 2019 My UART is broken could you test this patch ? https://github.com/clementperon/u-boot/commit/dc1abccb3628aefa6df3d44e027f33d8afc3fc86 Thanks
martinayotte Posted April 8, 2019 Author Posted April 8, 2019 On 4/8/2019 at 3:52 PM, froezus said: My UART is broken Expand You should do like me : I have more than a dozen of USB-TTL around, almost every boards have one, so I don't have to waste time unplugging/plugging them while testing. I've even placed a new order on eBay to get more ... On 4/8/2019 at 3:52 PM, froezus said: could you test this patch ? Expand Tested on OPiOnePlus, now doing the OPiLite2 and OPi3 ... Patch is already committed to Armbian ! Thanks a lot for the help ! EDIT : OPiLite2 and OPi3 tested too ... 1
frozeus Posted April 8, 2019 Posted April 8, 2019 I made a short circuit on my board and the TX pin is no more working...
martinayotte Posted April 8, 2019 Author Posted April 8, 2019 On 4/8/2019 at 4:34 PM, froezus said: I made a short circuit on my board and the TX pin is no more working... Expand Oh ! On the board side ... Next time, it is better to short the USB-TTL side, they are less expensive ...
frozeus Posted April 8, 2019 Posted April 8, 2019 On 4/8/2019 at 4:38 PM, martinayotte said: Oh ! On the board side ... Next time, it is better to short the USB-TTL side, they are less expensive ... Expand Yes, at least the RX is still working. BTW i have sent the patch for U-Boot if you could add your "Tested-by" tag for the reset patch. Thanks
ilchenko Evgeny Posted April 8, 2019 Posted April 8, 2019 On 4/8/2019 at 2:49 PM, froezus said: You just need to put it in build/patch/atf/atf-sunxi64/ Expand i cant find this path(
frozeus Posted April 8, 2019 Posted April 8, 2019 It has been merged so no need to add : https://github.com/armbian/build/tree/master/patch/atf/atf-sunxi64
ilchenko Evgeny Posted April 8, 2019 Posted April 8, 2019 On 4/8/2019 at 5:34 PM, froezus said: It has been merged so no need to add : https://github.com/armbian/build/tree/master/patch/atf/atf-sunxi64 Expand hmmm, orange pi 3 does not support? Only supported boards? how i can fix reboot on orange pi 3 ?
martinayotte Posted April 8, 2019 Author Posted April 8, 2019 On 4/8/2019 at 8:21 PM, ilchenko Evgeny said: how i can fix reboot on orange pi 3 ? Expand I've committed both Megi and Froezus patches earlier today in Armbian build scripts, so you simply need to recompile a new U-Boot and install it.
frozeus Posted April 8, 2019 Posted April 8, 2019 I have proposed a proper patch to ATF hope it will be accepted soon https://github.com/ARM-software/arm-trusted-firmware/pull/1926
martinayotte Posted April 9, 2019 Author Posted April 9, 2019 On 4/8/2019 at 10:23 PM, froezus said: I have proposed a proper patch to ATF hope it will be accepted soon Expand I'm a bit confused ... @megi patch seems to be H6 specific, but yours seen to affect all Allwinners SoC ... Can you details ? ...
frozeus Posted April 9, 2019 Posted April 9, 2019 no the SUNXI_WDT_QUIRK is only set to 1 in sun50i_h6/platform.mk not for all platforms.
Icenowy Posted April 9, 2019 Posted April 9, 2019 I tested on a Rongpin RP-H6B development board, and it also resets properly with normal WDOG. So maybe only OPi's are affected?
dolphs Posted April 9, 2019 Posted April 9, 2019 just compiled fresh full OS image ( Armbian_5.78_Orangepioneplus_Debian_stretch_dev_5.0.7.img ) but alas " reboot " hangs, so therefore my guess is I was too early and will wait another few days building from scratch, thanks for your efforts! :~/armbian/patch/atf/atf-sunxi64$ ls -la total 36 drwxrwxr-x 4 dolphs dolphs 4096 Apr 9 16:32 . drwxrwxr-x 5 dolphs dolphs 4096 Mar 11 00:03 .. -rw-r--r-- 1 root root 902 Apr 9 16:32 0001-Fix-reset-issue-on-H6-by-using-R_WDOG.patch -rw-rw-r-- 1 dolphs dolphs 1112 Mar 11 00:03 add-SRAM-mapping-for-SCPI.patch.disabled drwxrwxr-x 2 dolphs dolphs 4096 Apr 9 16:32 board_pine64so drwxrwxr-x 2 dolphs dolphs 4096 Mar 11 00:03 board_pinebook-a64 -rw-rw-r-- 1 dolphs dolphs 1079 Mar 11 00:03 enable-a53-errata-workaround.patch.disabled -rw-rw-r-- 1 dolphs dolphs 1315 Mar 11 00:03 enable-additional-regulators.patch -rw-rw-r-- 1 dolphs dolphs 525 Mar 11 00:03 set-rsb-to-nonsec.patch Just noticed the patch is added with root user instead of mine, perhaps need to chown it and give it another try?
Recommended Posts